Add-Ons page: show built-in payment gateways as always-active cards (RFC) by tuguirazvan · Pull Request #3195 · Strategy11/formidable-forms

tuguirazvan · 2026-07-21T13:47:59Z

Related ticket https://linear.app/strategy11/issue/DES-9/payment-processor-add-ons-in-lite-v-stripe-pro

Lite includes Stripe, Square, and PayPal processing, but the Add-Ons page presents them as Business-locked add-ons, so users think they can't take payments without upgrading.

In this update,

Stripe, Square, and PayPal Commerce appear as always-active cards — toggle on and disabled with an explanatory tooltip, no padlock, and a View Docs footer.
The Stripe and PayPal Standard add-ons display as Stripe Pro and PayPal Legacy (names only, until the add-ons API adopts them).
Clicking a disabled add-on toggle no longer triggers a JS error.

🤖 Generated with Claude Code

Summary by CodeRabbit

New Features
- Added built-in payment gateway add-ons to the Add-Ons page.
- Added support for Stripe Pro and PayPal Legacy display names.
- Added icons for additional payment integrations.
- Built-in add-ons now appear active and include documentation links where available.
Bug Fixes
- Prevented disabled add-on toggles from triggering actions.
- Improved add-on card controls and status display.

@SInCE

Lite ships Stripe, Square, and PayPal processing in core, but the Add-Ons page presented "Stripe" and "PayPal Standard" as Business-locked add-ons, which reads as "you can't take payments without Business". - Inject Stripe, Square, and PayPal as built_in entries (same pattern as the hardcoded Formidable Pro card). They render as active cards: toggle on and disabled, no padlock, View Docs footer, and a frm_help tooltip explaining the toggle is always on. - Built-in cards count under the stock "Active" sidebar tab. - Present the add-ons that extend the built-in gateways as their tiers: "Stripe" becomes "Stripe Pro" (excerpt leads with removing the 3% transaction fee), "PayPal Standard" becomes "PayPal Legacy". These are display-level overrides until the add-ons API reflects the naming. Experiment/RFC quality: @SInCE placeholders, untranslated strings, and Business/Elite states are untested on a licensed install. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Clicking a disabled toggle (built-in gateways, Formidable Pro) ran the activate/deactivate action lookup and crashed on the missing action button. Matches the guard on the add_mock_addons branch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Aligns with the naming used on the add_mock_addons branch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

The overridden Stripe Pro excerpt claimed installing the add-on removes the 3% transaction fee, but fee removal is gated by the license. Keep the add-ons' original excerpts and only override the display names. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

coderabbitai · 2026-07-21T13:48:48Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 13e449bc-b624-4df1-a5c4-6c3387d11f9a

📥 Commits

Reviewing files that changed from the base of the PR and between c00002d and 1b5fa9c.

📒 Files selected for processing (4)

classes/controllers/FrmAddonsController.php
classes/helpers/FrmAddonsHelper.php
classes/views/addons/addon.php
tests/cypress/e2e/Add-Ons/validateAddOnsPage.cy.js

🚧 Files skipped from review as they are similar to previous changes (3)

classes/helpers/FrmAddonsHelper.php
classes/views/addons/addon.php
classes/controllers/FrmAddonsController.php

📝 Walkthrough

Walkthrough

The Add-Ons page now includes predefined built-in payment gateways. Built-in entries receive active status, bypass locking, use expanded icon mappings, render dedicated controls and documentation links, and ignore disabled toggle interactions.

Changes

Built-in add-on support

Layer / File(s)	Summary
Built-in add-on catalog and status `classes/controllers/FrmAddonsController.php`, `tests/cypress/e2e/Add-Ons/validateAddOnsPage.cy.js`	The controller merges predefined built-in gateways, applies display-name overrides, marks built-in add-ons as active, and updates PayPal Legacy assertions.
Built-in add-on helper state `classes/helpers/FrmAddonsHelper.php`	The helper tracks built-in state, bypasses locking, exposes the state, and adds gateway icon mappings.
Built-in rendering and toggle behavior `classes/views/addons/addon.php`, `js/src/addons-page/events/addonToggleListener.js`, `js/addons-page.js`	Built-in cards render dedicated toggle and documentation behavior, while disabled toggle inputs no longer trigger actions.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Strategy11/formidable-forms#1802: Both changes modify the Add-Ons controller and add-on card rendering paths.
Strategy11/formidable-forms#1963: Both changes update PayPal add-on page validation from “PayPal Standard” to “PayPal Legacy”.

Suggested reviewers: crabcyborg

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: built-in payment gateways are shown as always-active cards on the Add-Ons page.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch experiment/built-in-gateway-cards

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

deepsource-io · 2026-07-21T13:49:17Z

DeepSource Code Review

We reviewed changes in 057c563...1b5fa9c on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Jul 21, 2026 2:45p.m.	Review ↗
JavaScript		Jul 21, 2026 2:45p.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Release tooling replaces x.x with the version number. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Fixes the two PHPCS Squiz.Commenting.LongConditionClosingComment errors. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Searching by the original name still finds the card; only the displayed name assertions change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

mikeldalton · 2026-07-23T20:51:03Z

Stripe Pro: "Non Stripe-Link payment options, After Payment settings, capture payments later, and more advanced settings"
PayPal Legacy: "The previous standalone PayPal integration, for sites already using it."

Crabcyborg · 2026-07-27T13:35:39Z

Thanks @tuguirazvan

I wonder if Stripe and Stripe Pro should be closer to one another?

I also wonder if we should be going for the same icon for both? It seems funny that there are 2 stripe icons in use here.

tuguirazvan · 2026-07-28T11:11:34Z

@Crabcyborg

Haha, you're right. Yes, we def should have the icons the same, I haven't realized they are different. We should use what we have now in the live version (the inline version, not square one). I'm ok with having them closer, maybe replace Square with Stripe Pro?

Also, do you want to make these changes yourself or want me to make them?

Crabcyborg · 2026-07-28T16:12:04Z

@tuguirazvan I can wrap this PR up if you'd prefer to do it that way.

Thanks for working on this!

tuguirazvan · 2026-07-28T16:27:27Z

@Crabcyborg Yeah, how you preffer, you're the master here. :D I'm still poking around. Hopefully I'm not slowing you down. I just try to help!

tuguirazvan and others added 4 commits July 20, 2026 16:38

Rename the built-in PayPal card to PayPal Commerce

0dc4b80

Aligns with the naming used on the add_mock_addons branch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Use the x.x placeholder in new @SInCE tags

a20b13b

Release tooling replaces x.x with the version number. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

tuguirazvan added run analysis run tests labels Jul 21, 2026

tuguirazvan changed the title ~~Experiment/built in gateway cards~~ Add-Ons page: show built-in payment gateways as always-active cards (RFC) Jul 21, 2026

tuguirazvan marked this pull request as draft July 21, 2026 14:16

tuguirazvan and others added 2 commits July 21, 2026 17:44

Add missing end comments for long conditions

79de257

Fixes the two PHPCS Squiz.Commenting.LongConditionClosingComment errors. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Update the add-ons page e2e test for the PayPal Legacy rename

1b5fa9c

Searching by the original name still finds the card; only the displayed name assertions change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

tuguirazvan marked this pull request as ready for review July 21, 2026 15:15

tuguirazvan requested a review from Crabcyborg July 23, 2026 14:04

Navigation Menu

Uh oh!

Add-Ons page: show built-in payment gateways as always-active cards (RFC) - #3195

Add-Ons page: show built-in payment gateways as always-active cards (RFC)#3195
tuguirazvan wants to merge 7 commits into
masterfrom
experiment/built-in-gateway-cards

tuguirazvan commented Jul 21, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 21, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

deepsource-io Bot commented Jul 21, 2026 •

edited

Loading

Uh oh!

mikeldalton commented Jul 23, 2026

Uh oh!

Crabcyborg commented Jul 27, 2026

Uh oh!

tuguirazvan commented Jul 28, 2026 •

edited

Loading

Uh oh!

Crabcyborg commented Jul 28, 2026

Uh oh!

tuguirazvan commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tuguirazvan commented Jul 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

deepsource-io Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

mikeldalton commented Jul 23, 2026

Uh oh!

Crabcyborg commented Jul 27, 2026

Uh oh!

tuguirazvan commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Crabcyborg commented Jul 28, 2026

Uh oh!

tuguirazvan commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tuguirazvan commented Jul 21, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 21, 2026 •

edited

Loading

deepsource-io Bot commented Jul 21, 2026 •

edited

Loading

tuguirazvan commented Jul 28, 2026 •

edited

Loading